fix(release): make sdist smoke check version-agnostic (unblock v1.0.1 publish)#29
Merged
Merged
Conversation
The build-plugin sdist smoke step hardcoded `assert __version__ == '1.0.0'`. After the 1.0.1 version bump this assertion failed, so the sdist job errored and blocked the publish even though both Rust binary legs (Linux + macOS aarch64) built cleanly — the v1.0.1 release run got as far as artifact builds and then skipped Create-Release. Assert the module constant equals the installed distribution metadata version instead of a literal, so a release version bump can never silently break this gate again while still catching module/packaging version drift. Refs clarion-12667da9f5. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v1.0.1 release run failed at Build Python plugin sdist →
smoke install sdist, which hardcodedassert clarion_plugin_python.__version__ == '1.0.0'. After the 1.0.1 bump the module reports1.0.1, so the assertion failed and theCreate GitHub Releasejob was skipped — even though both Rust binary legs (Linux x86_64 + macOS aarch64) built cleanly.Fix
Assert the module version equals the installed distribution metadata version rather than a hardcoded literal. Version-agnostic, so a future bump can't silently break this gate, while still catching real module/packaging drift. Verified locally: fresh install →
1.0.1 == 1.0.1.Refs clarion-12667da9f5. Unblocks re-cutting the v1.0.1 release.
🤖 Generated with Claude Code